[PATCH] D140702: [exegesis] "Skip codegen" dry-run mode

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-exegesis.rst:199-207
+.. option:: --benchmark-phase=[skip-codegen|skip-full-codegen|skip-measurements|measure]
 
   By default, when `-mode=` is specified, the generated snippet will be executed
   and measured, and that requires that we are running on the hardware for which
   the snippet was generated, and that supports performance measurements.
   But sometimes, you just want to generate snippets, and this is exactly what
+  this options allows one to do. It's possible to also skip target machine code
----------------
lebedev.ri wrote:
> gchatelet wrote:
> > I'm confused by this documentation.
> > Can we list the options and describe what they mean exactly?
> > What is the difference between `skip-codegen` and `skip-full-codegen`?
> > What are the outputs for the different stages?
> > Maybe name the options according to what they do instead of what it doesn't do.
> Is this better?
> I'm effectively modelling them as stop-before/stop-after of the `opt`
This is better but I'd avoid using the `skip-` part as it's unclear what it's actually doing.
So yes the documentation is improved but changing the flags themselves into more meaningful commands would help as well I think.
How about:
 - `prepare-snippet`
 - `prepare-and-dump-snippet`
 - `prepare-measured-code`
 - `measure`



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140702/new/

https://reviews.llvm.org/D140702