[PATCH] D140890: llvm-reduce: Reduce individual operands of named metadata
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 3 07:32:38 PST 2023
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM with one bit inline.
================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceMetadata.cpp:57
+
+ NamedNode->clearOperands();
+ for (MDNode *KeptOperand : KeptOperands)
----------------
Seems like it’d be nice to precede this with a check that anything has changed (if nothing has changed, `continue`…)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140890/new/
https://reviews.llvm.org/D140890
More information about the llvm-commits
mailing list