[llvm] 3f3b71a - llvm-reduce: Try to fix error message test on windows

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 06:58:33 PST 2023


Author: Matt Arsenault
Date: 2023-01-03T09:58:29-05:00
New Revision: 3f3b71ae02af434981a73acced146f4d849a87fc

URL: https://github.com/llvm/llvm-project/commit/3f3b71ae02af434981a73acced146f4d849a87fc
DIFF: https://github.com/llvm/llvm-project/commit/3f3b71ae02af434981a73acced146f4d849a87fc.diff

LOG: llvm-reduce: Try to fix error message test on windows

It seems the execute implementations have gone out of their way to
produce inconsistent error messages. The unix version explicitly
checks if the file exists before trying to execute. The windows
version checks if it's executable. I don't understand why they
wouldn't just try the execution and check the error code.

Added: 
    

Modified: 
    llvm/test/tools/llvm-reduce/fail-execute-test.test

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-reduce/fail-execute-test.test b/llvm/test/tools/llvm-reduce/fail-execute-test.test
index badf37649652..1582ece88e9c 100644
--- a/llvm/test/tools/llvm-reduce/fail-execute-test.test
+++ b/llvm/test/tools/llvm-reduce/fail-execute-test.test
@@ -1,3 +1,3 @@
 # RUN: not llvm-reduce --test=%s.NotAFileInTestingDir %p/Inputs/test-output-format.ll 2>&1 | FileCheck -DFILENAME=%s.NotAFileInTestingDir --strict-whitespace %s
 
-# CHECK: Error running interesting-ness test: Executable "[[FILENAME]]" doesn't exist!{{$}}
\ No newline at end of file
+# CHECK: Error running interesting-ness test: {{(Executable "[[FILENAME]]" doesn't exist$)?(program not executable$)?}}
\ No newline at end of file


        


More information about the llvm-commits mailing list