[PATCH] D140392: [SLP][AArch64] Incorrectly estimated intrinsic as a function call
Dinar Temirbulatov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 3 06:32:50 PST 2023
dtemirbulatov added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7576
+ SmallVector<Type *, 4> Tys;
+ CallInst *CI = cast<CallInst>(II);
+ for (auto &ArgOp : CI->args())
----------------
ABataev wrote:
> Do you still need this cast to get the list of arguments?
yes, in order to get correctly prepared ICA. Otherwise sometime we could get incorrect cost or compile time error if we provide empty set of arguments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140392/new/
https://reviews.llvm.org/D140392
More information about the llvm-commits
mailing list