[PATCH] D140888: OpenMPOpt: Fix introducing empty nvvm.annotations into module

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: jdoerfert, jhuber6, JonChesterfield, ggeorgakoudis.
Herald added subscribers: mattd, gchakrabarti, ormris, guansong, hiraditya, yaxunl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added subscribers: sstefan1, wdng.
Herald added a project: LLVM.

https://reviews.llvm.org/D140888

Files:
  llvm/lib/Transforms/IPO/OpenMPOpt.cpp
  llvm/test/Transforms/OpenMP/no-insert-nvvm-annotations.ll


Index: llvm/test/Transforms/OpenMP/no-insert-nvvm-annotations.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/OpenMP/no-insert-nvvm-annotations.ll
@@ -0,0 +1,12 @@
+; RUN: opt -S -passes=openmp-opt < %s | FileCheck %s
+; Make sure nnvm.annotations isn't introduced into the module
+
+; CHECK-NOT: nvvm
+
+define amdgpu_kernel void @foo() {
+  ret void
+}
+
+!llvm.module.flags = !{!0}
+
+!0 = !{i32 7, !"openmp", i32 50}
Index: llvm/lib/Transforms/IPO/OpenMPOpt.cpp
===================================================================
--- llvm/lib/Transforms/IPO/OpenMPOpt.cpp
+++ llvm/lib/Transforms/IPO/OpenMPOpt.cpp
@@ -5124,7 +5124,7 @@
 
 KernelSet llvm::omp::getDeviceKernels(Module &M) {
   // TODO: Create a more cross-platform way of determining device kernels.
-  NamedMDNode *MD = M.getOrInsertNamedMetadata("nvvm.annotations");
+  NamedMDNode *MD = M.getNamedMetadata("nvvm.annotations");
   KernelSet Kernels;
 
   if (!MD)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140888.485971.patch
Type: text/x-patch
Size: 998 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230103/37c428f3/attachment.bin>