[PATCH] D139780: [AMDGPU] Unify divergent nodes if the PostDom tree has one root
Ruiling, Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 2 22:23:06 PST 2023
ruiling added a comment.
In D139780#4022193 <https://reviews.llvm.org/D139780#4022193>, @gandhi21299 wrote:
> - inserted a check for switch terminator, ...
I don't think just checking for switch terminator would work. My suggestion is don't handle switch here. The pass has never been designed to work with switch terminator, and it needs non-trivial work to support switch terminator in this pass. As we already lower switch terminator before this pass, I think it is not important to support switch terminator in this pass now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139780/new/
https://reviews.llvm.org/D139780
More information about the llvm-commits
mailing list