[PATCH] D139254: Enhance stack protector

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 2 16:36:22 PST 2023


xiangzhangllvm added a comment.

In D139254#4019890 <https://reviews.llvm.org/D139254#4019890>, @LuoYuanke wrote:

> In D139254#4019615 <https://reviews.llvm.org/D139254#4019615>, @lanza wrote:
>
>> This diff is a ~0.5% size regression under -Oz when building with `-fstack-protector`. Is this reasonably expected? And one that should be expected given that it's considered to be a correctness fix? cc @smeenai
>
> I think the size increasement is expected because it inserts more stack corruption checks. Do you find any unexpected check?

That is right, sorry for not see this comment in time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139254/new/

https://reviews.llvm.org/D139254



More information about the llvm-commits mailing list