[PATCH] D140844: [InstCombine] Canonicalize gep of addrspacecast

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:2473
+      return replaceInstUsesWith(GEP, NewAC);
+    }
+  }
----------------
arsenm wrote:
> We probably shouldn't be reassociating if either address space is non-integral. I think that was one of the fixes that never happened for the existing code
But yes,  moving the addrspacecast up makes more sense 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140844/new/

https://reviews.llvm.org/D140844