[PATCH] D140820: [JITLink][RISCV] Homogenize immediate handling

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 2 01:26:59 PST 2023


Hahnfeld added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp:228
       uint32_t RawInstr = *(little32_t *)FixupPtr;
-      *(little32_t *)FixupPtr = RawInstr | Imm20 | Imm10_1 | Imm11 | Imm19_12;
+      *(little32_t *)FixupPtr =
+          (RawInstr & 0xFFF) | Imm20 | Imm10_1 | Imm11 | Imm19_12;
----------------
StephenFan wrote:
> It's better to change this in another commit.
You mean the change to `RawInstr & 0xFFF` in a separate commit? Will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140820/new/

https://reviews.llvm.org/D140820



More information about the llvm-commits mailing list