[PATCH] D140647: Handle simple diamond CFG hoisting in DivRemPairs.

Owen Anderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 25 20:00:40 PST 2022


resistor updated this revision to Diff 485265.
resistor added a comment.

Add negative tests. Enhance comments to explain the profitability heuristic.
Attempt to fix pre-existing correctness concerns WRT non-transferring predecessors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140647/new/

https://reviews.llvm.org/D140647

Files:
  llvm/lib/Transforms/Scalar/DivRemPairs.cpp
  llvm/test/Transforms/DivRemPairs/MSP430/div-rem-pairs.ll
  llvm/test/Transforms/DivRemPairs/Mips/div-rem-pairs.ll
  llvm/test/Transforms/DivRemPairs/PowerPC/div-rem-pairs.ll
  llvm/test/Transforms/DivRemPairs/RISCV/div-rem-pairs.ll
  llvm/test/Transforms/DivRemPairs/X86/div-expanded-rem-pair.ll
  llvm/test/Transforms/DivRemPairs/X86/div-rem-pairs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140647.485265.patch
Type: text/x-patch
Size: 12921 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221226/6670185f/attachment.bin>


More information about the llvm-commits mailing list