[PATCH] D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler.

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 25 18:16:15 PST 2022


barannikov88 accepted this revision.
barannikov88 added inline comments.


================
Comment at: llvm/lib/Target/Xtensa/Disassembler/XtensaDisassembler.cpp:178
+  if (Bytes.size() < 3) {
+    Size = 0;
+    return MCDisassembler::Fail;
----------------
(cosmetic) If you have only two bytes in the buffer, this method will be called twice, fail twice, and <unknown> will be printed twice, which is probably not what you want.
Setting Size = Bytes.size() avoids the issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64835/new/

https://reviews.llvm.org/D64835



More information about the llvm-commits mailing list