[PATCH] D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description.

[Andrei Safronov via Phabricator via llvm-commits]

andreisfr added inline comments.


================
Comment at: llvm/lib/Target/Xtensa/XtensaInstrFormats.td:217
+  field bits<16> Inst;
+  field bits<16> SoftFail = 0;
+  let Inst = 0x0;
----------------
barannikov88 wrote:
> * IIRC SoftFail is no longer necessary after [[ https://github.com/llvm/llvm-project/commit/23423c0ea8d414e56081cb6a13bd8b2cc91513a9 | this patch ]] (if you don't use this functionality, of course).
> * 'field' seems redundant, too (hasn't this keyword been deprecated?).
> * Do isCodeGenOnly instructions really need encoding bits?
Thank you for comments, I removed redundant code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64830/new/

https://reviews.llvm.org/D64830