[PATCH] D140593: [X86] Emit RIP-relative access to local function in PIC medium code model

Sun Dec 25 15:14:14 PST 2022

tkoeppe added inline comments.

================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:20492
   CodeModel::Model M = getTargetMachine().getCodeModel();
+
   if (Subtarget.isPICStyleRIPRel() &&
----------------
MaskRay wrote:
> tkoeppe wrote:
> > MaskRay wrote:
> > > Delete this blank line.
> > Are you sure? I thought since `M` is used in multiple conditions below now, it'd be better to not "stick" to any one of them, so it's easier to spot, and so it doesn't look like it just appertains to one of the if statements. I can change it if you like, but I thought it looks clearer with this blank line.
> I'm sure. The prevailing style is compact, and the argument that it's used twice isn't really a strong one.
OK, sure, done!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140593/new/

https://reviews.llvm.org/D140593