[PATCH] D140647: Handle simple diamond CFG hoisting in DivRemPairs.

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added a comment.

In D140647#4016111 <https://reviews.llvm.org/D140647#4016111>, @lebedev.ri wrote:

>   if(DivBB != PredBB && RemBB != PredBB && !HasDivRemOp)
>     continue; // Don't hoist both into predecessor if we don't have divrem instruction.

That sounds fine to me, too.
@resistor 
Could you please "port" PPC's @no_domination test to a couple of more targets to make sure there are no regressions? E.g. AArch64 (no rem), RISCV (rem, but no divrem) and MSP430 (libcall rem, no divrem)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140647/new/

https://reviews.llvm.org/D140647