[PATCH] D140636: [Support] Fix what I think is an off by 1 bug in UnsignedDivisionByConstantInfo.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 24 17:16:26 PST 2022


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

I've added exhaustive test coverage for this division expansion: 066b492b747a7e00f537eab9f0196575522ec285 <https://reviews.llvm.org/rG066b492b747a7e00f537eab9f0196575522ec285> (that now always tests bit widths 2..12)
And additionally brute-forced it for i16, without and with this patch, using: https://godbolt.org/z/3xGzTM881.
This change does not cause any changes, our existing expansion is correct regardless.
`TargetLowering::BuildUDIV()` seen a lot of changes since then.

I'm going to go ahead and stamp this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140636/new/

https://reviews.llvm.org/D140636



More information about the llvm-commits mailing list