[PATCH] D140202: [lld][ARM][2/3]Big Endian support - Word invariant support

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Please answer why --be8 and --be32 are added and what the references are.



================
Comment at: lld/ELF/ARMErrataFix.cpp:181
+  if (config->be32 || config->be8)
+    error("Unsupported for big-endian");
   if (isARM)
----------------
don't capitalize. see other diagnostics. this incompatibility check should be added to Driver.cpp see " may not be used together"


================
Comment at: lld/ELF/Arch/ARM.cpp:918
+template TargetInfo *elf::getARMTargetInfo<llvm::object::ELF32BE>();
\ No newline at end of file

----------------
Add newline at end of file


================
Comment at: lld/ELF/Driver.cpp:1075
+  config->be8 = args.hasArg(OPT_be8);
+  if (config->be8) error("byte invariant not yet supported");
+  config->be32 = args.hasArg(OPT_be32);
----------------
If not yet supported, just delete this option. Are use cases using this option still useful?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140202/new/

https://reviews.llvm.org/D140202