[PATCH] D69542: Full Restrict Support - single patch

Sat Dec 24 01:48:26 PST 2022

nikic added a comment.

In D69542#3933523 <https://reviews.llvm.org/D69542#3933523>, @jeroen.dobbelaere wrote:

> In D69542#3932775 <https://reviews.llvm.org/D69542#3932775>, @vzakhari wrote:
>
>> Hi @jeroen.dobbelaere, can you please rebase the patch?  I would like to try `@llvm.noalias` for Flang generated IR, but the patch would not apply cleanly.  Thank you!
>
> Hi @vzakhari , I'll give it another respin, but it will likely take a week or 2-3.

If there's a version of the patch that applies to either release/15.x or current main, I'd like to test this against Rust. The last time I tried this I didn't get far due to the type mangling issues, but those have been fixed, so I think it would be worthwhile to try again, both from a correctness and compile-time perspective.

Especially the ptr_provenance change seems like it could have many silent failure points. I know we have a lot of code that assumes that a pointer used by a load is the loaded pointer, which is true right now, but does not hold with ptr_provenance.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69542/new/

https://reviews.llvm.org/D69542