[PATCH] D140636: [Support] Fix what I think is an off by 1 bug in UnsignedDivisionByConstantInfo.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 23 16:01:04 PST 2022


craig.topper added a comment.

In D140636#4015758 <https://reviews.llvm.org/D140636#4015758>, @barannikov88 wrote:

> https://github.com/llvm/llvm-project/commit/3aab6a86a263369fc49a6180f9163d0077435a02
> https://github.com/llvm/llvm-project/issues/13698
>
> There are a few testcases that might worth checking / adding:
> https://github.com/llvm/llvm-project/issues/13698#issuecomment-980909412

Those test cases test i8 udiv by 78 and 116. The tests for those are still in test/CodeGen/X86/div-by-constant.ll and did not change with this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140636/new/

https://reviews.llvm.org/D140636



More information about the llvm-commits mailing list