[PATCH] D140638: [Codegen][LegalizeIntegerTypes] New legalization strategy for scalar shifts w/ shift amount by a multiple of CHAR_BIT

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 23 15:55:47 PST 2022


lebedev.ri added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:4188
+  // Get the pointer into stack slot from which we need to load.
+  ByteOffset = DAG.getZExtOrTrunc(ByteOffset, dl, StackPtr.getValueType());
+  SDValue AdjStackPtr =
----------------
This is a bug, it should be sext, patch incoming.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140638/new/

https://reviews.llvm.org/D140638



More information about the llvm-commits mailing list