[PATCH] D140640: AMDGPU: Fix enqueue block lowering for opaque pointers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 23 15:20:38 PST 2022


arsenm created this revision.
arsenm added reviewers: yaxunl, rampitec, cdevadas, AMDGPU, nikic.
Herald added subscribers: kosarev, foad, kerbowa, hiraditya, tpr, dstuttard, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

This was looking for a specific constant cast of the function, when
the type doesn't matter. Doesn't bother trying to handle typed
pointers, it will just assert.

      

Things probably don't work completely correctly if the block kernel
address is captured somewhere else, but that wouldn't work before
either. The uses should really be loads out of the handle, and the
handle initializer should contain the kernel address.


https://reviews.llvm.org/D140640

Files:
  llvm/lib/Target/AMDGPU/AMDGPUOpenCLEnqueuedBlockLowering.cpp
  llvm/test/CodeGen/AMDGPU/enqueue-kernel.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140640.485166.patch
Type: text/x-patch
Size: 8542 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221223/d5479b5f/attachment.bin>


More information about the llvm-commits mailing list