[PATCH] D140635: Enabled DFAJumpThreading by Default

Fri Dec 23 15:04:49 PST 2022

nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

Isn't this missing updates for pipeline tests?

Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=387c1573f89117687f4b964ae3a90ea7c91a4f90&to=2a66b841e34f385331226d2b4f89fffd1840cda1&stat=instructions%3Au

This is much more expensive than when I tested this the last time on August 2nd, 2021: https://llvm-compile-time-tracker.com/compare.php?from=380b8a603c6e8997819726b15a76b8f6c94aa21a&to=abb759c879725b7bc09a466e92c9b9eca7f8f483&stat=instructions:u At that time, the pass was pretty cheap, and as such a reasonable tradeoff. Now this doesn't seem to be the case anymore.

I looked through the history of the pass, and this is the only commit that looked like a significant change, so possibly it is at fault: https://github.com/llvm/llvm-project/commit/8b0d7634743965948234b666c77393d4dd8535d7

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140635/new/

https://reviews.llvm.org/D140635