[PATCH] D140631: [lld-macho][test] Remove redundant -lSystem flags

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 23 09:29:41 PST 2022


thakis added a comment.

I'm kind of against this change: I often change `%lld` to `ld` in tests locally to compare behavior to ld64. This makes that impossible, without a big upside in return.

(I kind of wish we would've just added explicit `-lSystem` flags in that other patch instead of changing the substitution as well, for the same reason, and for "explicit is better than implicit")


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140631/new/

https://reviews.llvm.org/D140631



More information about the llvm-commits mailing list