[PATCH] D140581: [NVPTX] Enforce minumum alignment of 4 for byval parametrs in a function prototype

Luke Drummond via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 23 04:16:00 PST 2022


ldrumm added a comment.

In your commit message:

- s/parametrs/parameters

I'd prefer to split off a separate test that only checks the alignment of various calls, rather than reuse the byval bitcast test. Otherwise LGTM, but I'd wait on someone more familiar with ptx, e.g. ~tra


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140581/new/

https://reviews.llvm.org/D140581



More information about the llvm-commits mailing list