[llvm] 22bf4a7 - [NFC][NVPTX] Remove dead comment and commented code

Luke Drummond via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 23 04:11:17 PST 2022


Author: Luke Drummond
Date: 2022-12-23T12:10:49Z
New Revision: 22bf4a7e89c07255856366f2710974642e482920

URL: https://github.com/llvm/llvm-project/commit/22bf4a7e89c07255856366f2710974642e482920
DIFF: https://github.com/llvm/llvm-project/commit/22bf4a7e89c07255856366f2710974642e482920.diff

LOG: [NFC][NVPTX] Remove dead comment and commented code

A confusing comment after the last return statement in
`NVPTXAsmPrinter::doFinalization` referred to a preprocessor macro
(NVISA) that has never existed since the NVPTX backend has been a part
of upstream llvm - as far as the pickaxe will tell me anyway. Thus I've
removed it.

Differential Revision: https://reviews.llvm.org/D140399

Added: 
    

Modified: 
    llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp b/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
index da1662e29c23..076f3949e531 100644
--- a/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
+++ b/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
@@ -913,15 +913,6 @@ bool NVPTXAsmPrinter::doFinalization(Module &M) {
   TS->outputDwarfFileDirectives();
 
   return ret;
-
-  //bool Result = AsmPrinter::doFinalization(M);
-  // Instead of calling the parents doFinalization, we may
-  // clone parents doFinalization and customize here.
-  // Currently, we if NVISA out the EmitGlobals() in
-  // parent's doFinalization, which is too intrusive.
-  //
-  // Same for the doInitialization.
-  //return Result;
 }
 
 // This function emits appropriate linkage directives for


        


More information about the llvm-commits mailing list