[PATCH] D140613: [APFloat] Remove workaround for old clang.

[Craig Topper via Phabricator via llvm-commits]

craig.topper created this revision.
craig.topper added reviewers: nikic, RKSimon, spatel, efriedma, lebedev.ri.
Herald added a subscriber: StephenFan.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added a project: LLVM.

The comment says this is for clang 3.3. I believe our build
requirements are newer than that so we can remove this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140613

Files:
  llvm/include/llvm/ADT/APFloat.h


Index: llvm/include/llvm/ADT/APFloat.h
===================================================================
--- llvm/include/llvm/ADT/APFloat.h
+++ llvm/include/llvm/ADT/APFloat.h
@@ -859,13 +859,6 @@
     APFLOAT_DISPATCH_ON_SEMANTICS(makeSmallestNormalized(Neg));
   }
 
-  // FIXME: This is due to clang 3.3 (or older version) always checks for the
-  // default constructor in an array aggregate initialization, even if no
-  // elements in the array is default initialized.
-  APFloat() : U(IEEEdouble()) {
-    llvm_unreachable("This is a workaround for old clang.");
-  }
-
   explicit APFloat(IEEEFloat F, const fltSemantics &S) : U(std::move(F), S) {}
   explicit APFloat(DoubleAPFloat F, const fltSemantics &S)
       : U(std::move(F), S) {}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140613.485059.patch
Type: text/x-patch
Size: 751 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221223/463cb121/attachment.bin>