[PATCH] D140592: [lld-macho] Skip re-loading archive if already loaded

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/MachO/Driver.cpp:327
           }
-          if (Error e = file->fetch(c, reason))
+          if (Error e = file->fetch(c, reason, true))
             error(toString(file) + ": " + reason +
----------------



================
Comment at: lld/MachO/InputFiles.cpp:2110
 
+  if (!skipCache && !seen.insert(mb->getBuffer()).second)
+    return Error::success();
----------------
We're doing this based on buffer contents? Where in ld64's source does it do that? That seems like very surprising semantics (and kinda bad for perf).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140592/new/

https://reviews.llvm.org/D140592