[PATCH] D108902: [PowerPC] Enable track-subreg-liveness by default

Thu Dec 22 18:27:18 PST 2022

shchenz accepted this revision as: shchenz.
shchenz added a comment.
This revision is now accepted and ready to land.

OK. Thanks for testing. Even though there is no improvement in the test suite, the LIT case changes show good improvement about COPY removal and register allocation. So this makes sense to me.

Please wait for some days in case @nemanjai has comments.

================
Comment at: llvm/test/CodeGen/PowerPC/pr45709.ll:43
 ; CHECK-NEXT:    stvx v2, 0, r3
+; CHECK-NEXT:    lfs f0, -16(r1)
 ; CHECK-NEXT:  .LBB0_6:
----------------
This may be caused by `undef`, I can not see any store to the same stack slot before? And the `f0` is a dead def, so I think this patch just exposes some dead def removal opportunity after eliminating some copy? It is good if we can improve this in following patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108902/new/

https://reviews.llvm.org/D108902