[PATCH] D140594: Add explicit template instantiation declarations.

Thomas Köppe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 17:33:18 PST 2022


tkoeppe created this revision.
tkoeppe added a reviewer: dblaikie.
Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini.
Herald added a reviewer: rriddle.
Herald added a project: All.
tkoeppe requested review of this revision.
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache.
Herald added a project: LLVM.

Explicit instantiations should be declared. Found with -Wundefined-func-template.


https://reviews.llvm.org/D140594

Files:
  llvm/mlir/include/mlir/IR/Dominance.h


Index: llvm/mlir/include/mlir/IR/Dominance.h
===================================================================
--- llvm/mlir/include/mlir/IR/Dominance.h
+++ llvm/mlir/include/mlir/IR/Dominance.h
@@ -24,6 +24,7 @@
 
 extern template class llvm::DominatorTreeBase<mlir::Block, false>;
 extern template class llvm::DominatorTreeBase<mlir::Block, true>;
+extern template class llvm::DomTreeNodeBase<mlir::Block>;
 
 namespace mlir {
 using DominanceInfoNode = llvm::DomTreeNodeBase<Block>;
@@ -109,6 +110,9 @@
   mutable DenseMap<Region *, llvm::PointerIntPair<DomTree *, 1, bool>>
       dominanceInfos;
 };
+
+extern template class DominanceInfoBase</*IsPostDom=*/true>;
+extern template class DominanceInfoBase</*IsPostDom=*/false>;
 } // namespace detail
 
 /// A class for computing basic dominance information. Note that this


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140594.484995.patch
Type: text/x-patch
Size: 830 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221223/8fbe67c0/attachment.bin>


More information about the llvm-commits mailing list