[PATCH] D140588: [unittest] Restructure plugin cmake target

IBricchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 14:40:40 PST 2022


IBricchi created this revision.
Herald added a project: All.
IBricchi updated this revision to Diff 484969.
IBricchi added a comment.
IBricchi updated this revision to Diff 484970.
IBricchi added reviewers: mtrofin, thakis.
IBricchi published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Add new lines to end of files


IBricchi added a comment.

Fix missindentation


IBricchi added a comment.

I moved the plugins into their own directory similar to https://reviews.llvm.org/D140559.

This reduces how many files need to be set as optional sources, however this folder still contains two unit tests as separate targets, so we still do need to have optional sources set when defining each target.

We could separate these two out into their own subdirectories aswell wdyt?


Move plugin source and cmake files into separate directory.
Typically cmake targets in LLVM have a single target per directory.
This change brings this unittest more inline with that structure.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140588

Files:
  llvm/unittests/Passes/CMakeLists.txt
  llvm/unittests/Passes/DoublerPlugin.cpp
  llvm/unittests/Passes/DoublerPlugin/CMakeLists.txt
  llvm/unittests/Passes/DoublerPlugin/DoublerPlugin.cpp
  llvm/unittests/Passes/TestPlugin.cpp
  llvm/unittests/Passes/TestPlugin/CMakeLists.txt
  llvm/unittests/Passes/TestPlugin/TestPlugin.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140588.484970.patch
Type: text/x-patch
Size: 5810 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221222/99277839/attachment.bin>


More information about the llvm-commits mailing list