[PATCH] D140517: [lld-macho] Flip string deduplication default

[Keith Smiley via Phabricator via llvm-commits]

keith added inline comments.


================
Comment at: lld/MachO/Options.td:61
+def no_deduplicate_strings: Flag<["--"], "no-deduplicate-strings">,
+    HelpText<"Disable string deduplication. This helps uncover undefined behavior comparing string literals and might have a performance benefit.">,
     Group<grp_lld>;
----------------
int3 wrote:
> Is comparing string pointers actually undefined, or just not what the code author intended?
Through the previous convos it sounded like it was UB but I can't find another source on that so I reworded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140517/new/

https://reviews.llvm.org/D140517