[PATCH] D139993: [LoopFusion] Sorting of undominated FusionCandidates crashes

Ramkrishnan Narayanan Komala via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 13:08:01 PST 2022


ram-NK marked an inline comment as done.
ram-NK added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:432
+        nonStrictlyPostDominate(RHSEntryBlock, LHSEntryBlock, DT, LHS.PDT);
+    if (WrongOrder && RightOrder) {
+      // If common predecessor of LHS and RHS post dominates both
----------------
aeubanks wrote:
> actually, do we have tests for all the WrongOrder/RightOrder combinations?
In the test case, added new predecessor for **entry.vector.body_crit_edge** from** middle.block15** to satisfy this condition.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139993/new/

https://reviews.llvm.org/D139993



More information about the llvm-commits mailing list