[PATCH] D140270: MIPS: emit .module and .nan directives only for first function

Nathan Chancellor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 11:40:15 PST 2022


nathanchance added a comment.

`cvise` spits out:

  __asm__("       .previous                       \n");
  void __attribute__set_raw_show_trace() {}



  $ clang --target=mips-linux-gnu -fno-integrated-as -c -o /dev/null traps.i
  /tmp/traps-0867c0.s: Assembler messages:
  /tmp/traps-0867c0.s:23: Error: .module is not permitted after generating code
  /tmp/traps-0867c0.s:26: Warning: .ent or .aent not in text section
  /tmp/traps-0867c0.s:48: Warning: .end not in text section
  clang-16: error: assembler command failed with exit code 1 (use -v to see invocation)

which appears to come from

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/mips/kernel/traps.c#n431

If this cannot be resolved by tomorrow, can the original patch be reverted and resubmitted with this fixed? This is breaking our and others' builds:

https://lore.kernel.org/CA+G9fYs=G_AAbkNOfLv7Oyvt6uOZ8CYun8fUQ-GghoKtbD5WAw@mail.gmail.com/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140270/new/

https://reviews.llvm.org/D140270



More information about the llvm-commits mailing list