[PATCH] D140166: [IR] return nullptr in Instruction::getInsertionPointAfterDef for CallBrInst
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 22 11:39:37 PST 2022
MaskRay added a subscriber: dblaikie.
MaskRay added a comment.
I agree that `; CHECK-NEXT-NOT: {{.*}}:` is uncommon and doesn't seem particularly useful in this case.
Actually, I think the test has a fair chance that it may bit rot and for maintainability we probably should a comment about the C++ source and some comments about what the test file test.
CC @dblaikie for the `coro-debug.l`l debate. The test was added from D33614 <https://reviews.llvm.org/D33614>.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140166/new/
https://reviews.llvm.org/D140166
More information about the llvm-commits
mailing list