[PATCH] D138953: llvm-reduce: Try to kill parallel workitems once we have a result.

Thu Dec 22 10:03:51 PST 2022

arsenm added a comment.

In D138953#3965112 <https://reviews.llvm.org/D138953#3965112>, @regehr wrote:

> In D138953#3965051 <https://reviews.llvm.org/D138953#3965051>, @arsenm wrote:
>
>> In D138953#3958442 <https://reviews.llvm.org/D138953#3958442>, @regehr wrote:
>>
>>> just fyi, the experience with this from C-Reduce is that first, killed compilers will tend to leave crap in /tmp or similar, and this builds up over time, but usually not that quickly.
>>
>> opt and llc don't do this, so I'm not too worried about this. Not sure what I would try to do about this anyway since tools tend to make up their own random unique filenames.
>
> probably the best option (only supported by some tools) is to tell the tool what tmp directory it should use, and then arrange for this to be removed when the reducer terminates.
>
>>> and second, this only worked robustly when I made a new process group to put the interestingness test into and then killed the entire group.
>>
>> Do you expect that in this patch? I don't see an existing abstraction for this
>
> fine to defer this (and the thing above) until needed, but please add a TODO sorta thing reminding us that we might want to do this later
>
> also when testing/using this functionality, definitely keep an eye out for things that keep running past when you try to kill them, because you didn't actually kill them but only killed some other process

Core files are now turned off by default as of 95abdeba6152c3fa15e96b4bababe6311bc9c118 <https://reviews.llvm.org/rG95abdeba6152c3fa15e96b4bababe6311bc9c118>

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138953/new/

https://reviews.llvm.org/D138953