[PATCH] D139184: [LLD][Windows]Feature "checksum" for Windows PE

Thu Dec 22 09:51:36 PST 2022

aaron.ballman added a comment.

In D139184#4013034 <https://reviews.llvm.org/D139184#4013034>, @Qfrost911 wrote:

> In D139184#3983197 <https://reviews.llvm.org/D139184#3983197>, @tonic wrote:
>
>> Hello! Please hold off on approving this patch as its pending legal review. Thanks!
>
> Hi, did you mean should I keep waiting, or should I add some tests?

You should keep waiting -- the LLVM Foundation lawyers need some time to review the legal aspects of the contribution (which can take a fair amount of time, especially given the holiday season). That said, I'd be curious to hear what caused the foundation lawyer involvement in the first place given that PE32 is a publicly documented format (https://learn.microsoft.com/en-us/windows/win32/debug/pe-format); as a reviewer, it'd be helpful for me to know what to watch out for in this space.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139184/new/

https://reviews.llvm.org/D139184