[PATCH] D140560: AMDGPU: Fix broken opaque pointer handling in printf pass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: sameerds, AMDGPU, yaxunl, vikramRH, rampitec.
Herald added subscribers: kosarev, foad, kerbowa, hiraditya, arichardson, tpr, dstuttard, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

This was directly considering the pointee type, and also applying
special semantics to constant address space.

@vikramRH since you're looking at this in D138702 <https://reviews.llvm.org/D138702>, can you please do something
about the test coverage before touching this pass? There's no coverage of any of the
format string handling and I see obvious bugs in every part of it. The same initializer bugs I fixed 
for the format string in D140558 <https://reviews.llvm.org/D140558> are repeated for print of string later.


https://reviews.llvm.org/D140560

Files:
  llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp
  llvm/test/CodeGen/AMDGPU/opencl-printf.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140560.484856.patch
Type: text/x-patch
Size: 11755 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221222/2679dee4/attachment.bin>