[PATCH] D140548: [SPIR-V] Map IR function pointers to registers in ModuleAnalysis

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.h:134
   SmallVector<MachineInstr *, 4> GlobalVarList;
-  // Maps function names to coresponding function ID registers.
-  StringMap<Register> FuncNameMap;
+  // Maps functions to coresponding function ID registers.
+  DenseMap<const Function*, Register> FuncMap;
----------------
Typo coresponding


================
Comment at: llvm/test/CodeGen/SPIRV/function/multiple-anonymous-functions.ll:34
+  %b = sitofp i32 %a to float
+  %2 = call spir_func float @1(float %b)
+  ret void
----------------
Don't use anonymous values in tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140548/new/

https://reviews.llvm.org/D140548