[PATCH] D140546: [AMDGPU] Remove permlane discard vdst_in optimization from isel

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with test nit



================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.permlane.ll:853
   %tidx = call i32 @llvm.amdgcn.workitem.id.x()
-  %v = call i32 @llvm.amdgcn.permlane16(i32 12345, i32 %tidx, i32 %src1, i32 %src2, i1 1, i1 0)
+  %v = call i32 @llvm.amdgcn.permlane16(i32 undef, i32 %tidx, i32 %src1, i32 %src2, i1 1, i1 0)
   store i32 %v, ptr addrspace(1) %out
----------------
Should use poison


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.permlane.ll:1113
   %tidx = call i32 @llvm.amdgcn.workitem.id.x()
-  %v = call i32 @llvm.amdgcn.permlanex16(i32 12345, i32 %tidx, i32 %src1, i32 %src2, i1 1, i1 1)
+  %v = call i32 @llvm.amdgcn.permlanex16(i32 undef, i32 %tidx, i32 %src1, i32 %src2, i1 1, i1 1)
   store i32 %v, ptr addrspace(1) %out
----------------
Can you also change these "i1 1" and "i1 0" to "i1 true" and "i1 false" while you're touching the lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140546/new/

https://reviews.llvm.org/D140546