[PATCH] D140537: SIInsertWait: Skip tied source of d16 buffer instruction

Ruiling, Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 04:24:48 PST 2022


ruiling added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1184
+        if (Op.isTied() && Op.isUse() &&
+            (MI.getDesc().TSFlags & SIInstrFlags::D16Buf))
+          continue;
----------------
arsenm wrote:
> Don't see the point of the "Buf" part of the name, it's just D16
`D16` was renamed into `D16Buf` in D47434. I think it should be ok to change back? The only one user in cpp source code is: https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp#L8048 I don't know what it is doing here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140537/new/

https://reviews.llvm.org/D140537



More information about the llvm-commits mailing list