[PATCH] D134982: [X86] Add support for "light" AVX

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 02:54:03 PST 2022


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.td:619
+def TuningAllowLightAVX
+    : SubtargetFeature<"allow-light-avx", "AllowLightAVX", "true",
+                       "Enable generation of 256 AVX load/stores even if we prefer 128-bit">;
----------------
TokarIP wrote:
> RKSimon wrote:
> > Maybe rename this "allow-light-256-bit"?
> Done for the feature name, should I also rename other mentions of light avx?
Yes please maintain a consistent naming if you can - AVX is redundant imo and will confuse things if we ever try to do this for 512-bit vectors as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134982/new/

https://reviews.llvm.org/D134982



More information about the llvm-commits mailing list