[PATCH] D139685: [DAGCombine]Expand usage of CreateBuildVecShuffle to make full use of vector ops

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 18:50:47 PST 2022


pengfei added a comment.

In D139685#4010658 <https://reviews.llvm.org/D139685#4010658>, @lebedev.ri wrote:

> FWIW, i've recently looked at this method, and, irrespectively of this particular patch,
> indeed it misses a quite big number of opportunities, but it also has a very high impact
> on the produced DAG, so coming up with the right preconditions is not easy. Alternatively,
> we need a significant amount of yak shawing to deal with the new patterns.

It would be great if we can figure out with meticulous patterns. But I think it's still fine to land this as a small step forward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139685/new/

https://reviews.llvm.org/D139685



More information about the llvm-commits mailing list