[PATCH] D140493: [SROA] Support promotion in presence of variably-indexed loads

Wed Dec 21 16:38:57 PST 2022

lebedev.ri added a comment.

In D140493#4011883 <https://reviews.llvm.org/D140493#4011883>, @lebedev.ri wrote:

> In D140493#4011659 <https://reviews.llvm.org/D140493#4011659>, @lebedev.ri wrote:
>
>> In D140493#4011599 <https://reviews.llvm.org/D140493#4011599>, @nikic wrote:
>>
>>> FYI sqlite3 from llvm-test-suite fails to build in ReleaseLTO-g configuration with the following error:
>>>
>>>> /usr/bin/ld: error: LLVM gold plugin: Invalid value reference from metadata
>>
>> Yeah, this is a rough version of the patch, it still probably needs some polishing.
>
> All good now: https://llvm-compile-time-tracker.com/compare.php?from=4d255f9e3374ecc5a85ac30ecbe65f3a737dfe35&to=aaaef46a6e3ef5c21178f86a18ce8911113ab026&stat=instructions%3Au

Looks like caching makes things worse: https://llvm-compile-time-tracker.com/compare.php?from=967ba1a86d4f949e7663467b40abce0d97ac7673&to=247be4da9921aaf357db80032fce9a8d1d05414a&stat=instructions:u
Either switching to manual GEP expansion will help somewhat, or those are "expected" second-order effects.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140493/new/

https://reviews.llvm.org/D140493