[PATCH] D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/Target/TargetMachine.h:429
+  /// Provide safe downcast
+  LLVMTargetMachine *asLLVMTargetMachine() override { return this; }
+
----------------
I don't understand the point of this, there's no cast here


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:746
+
+void TargetPassConfig::removeExtension(ExtensionID ID) {
+  if (!GlobalExtensions.isConstructed())
----------------
Is removal ever really needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98591/new/

https://reviews.llvm.org/D98591