[PATCH] D139883: [llvm][CallBrPrepare] add llvm.callbr.landingpad intrinsic

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 15:09:59 PST 2022


void added a comment.

As we talked before, I *really* hate the use of an intrinsic here. We used an intrinsic for the old exception handling and it was nothing but buggy. Theoretically they work just fine, but the can't take into account issues due to inlining, block splitting, and other code motion changes (at least not without a hefty dose of special checks throughout the compiler). If we use an intrinsic here, I believe we're just going to revisit the errors of the past.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139883/new/

https://reviews.llvm.org/D139883



More information about the llvm-commits mailing list