[PATCH] D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS.

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 14:52:23 PST 2022


oontvoo added a comment.

In D140225#4011616 <https://reviews.llvm.org/D140225#4011616>, @int3 wrote:

> I feel bad for all the back-and-forth with @oontvoo's work, but in general I am in favor of things that improve ease of adoption. @keith's solution seems clean enough too. +1

It's really not a big deal 😃 (I'd just like to see a solution submitted the sooner the better)

Keith's proposal LGTM , as long as we have that option to opt-in to the more strict because I still don't think bad limker-options are completely harmless. For one, they takes up space. For two, if our toolchains generate bad linker-options then we'd really like to know to fix the bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140225/new/

https://reviews.llvm.org/D140225



More information about the llvm-commits mailing list