[PATCH] D135997: [Dominators] check indirect branches of callbr

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 14:31:20 PST 2022


void accepted this revision.
void added a comment.

One small nit. Otherwise LGTM.



================
Comment at: llvm/test/Verifier/callbr.ll:59
 
-;; Ensure you cannot use the return value of a callbr in indirect targets.
-; CHECK: Instruction does not dominate all uses!
-; CHECK-NEXT: #test4
+;; Ensure you can use the return value of a callbr in indirect targets.
 define i32 @test4(i1 %var) {
----------------
Could you add some "CHECK"s here? Or a comment like below (;; No issue!).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135997/new/

https://reviews.llvm.org/D135997



More information about the llvm-commits mailing list