[PATCH] D140333: [lld][COFF] Fix lld-link crash when several .obj files built with /Zi refer to a .pdb file that failed to load

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 12:45:35 PST 2022


thieta accepted this revision.
thieta added a comment.

Oh sorry for the late reply. I think removing the getter makes sense as well - it worked better when we had the earlier revision that copied string out of the Error etc.

Anyway LGTM and this hopefully fixes the crash we got reported internally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140333/new/

https://reviews.llvm.org/D140333



More information about the llvm-commits mailing list