[PATCH] D140210: [IPSCCP] Enable specialization of functions.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Ok, then I will comment on the other side of things.

This transformations is addressing an area of optimisations where we were behind and often comes up as a difference. As mentioned in the description, this will benefit a well known benchmark but it is a very general transformation so has the potential to trigger on a lot of cases (shown when e.g. specialisation is forced). I am not aware of any issues with the implementation, and the testing  done looks pretty extensive. So, worth giving this a try I think: LGTM.

Please wait a day in case there are more comments. And optional: enabling this looks worthy a mention in the release notes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140210/new/

https://reviews.llvm.org/D140210