[PATCH] D140088: Add LLVM type support for fp8

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Also needs bitcode compatibility.ll test



================
Comment at: llvm/test/Assembler/fp8.ll:2
+; RUN: llvm-as < %s | llvm-dis | FileCheck %s --check-prefix=ASSEM-DISASS
+; RUN: opt < %s -O3 -S | FileCheck %s --check-prefix=OPT
+; RUN: verify-uselistorder %s
----------------
no opt, especially -O3


================
Comment at: llvm/test/Assembler/fp8.ll:28-32
+define f8e4m3 @check_f8e4m3_constprop() {
+  %tmp = fadd f8e4m3 0xQ40, 0xQ40
+; OPT: 0xQ48
+  ret f8e4m3 %tmp
+}
----------------
The constant folding tests belong in test/Transforms/InstSimplify, and should cover the full range of floating point classes and operations


================
Comment at: llvm/test/Assembler/fp8.ll:61
+}
+
----------------
Should check math intrinsics


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140088/new/

https://reviews.llvm.org/D140088