[PATCH] D140382: [CodeGen] Add user interface for DetectDeadLanes

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 10:36:34 PST 2022


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/DetectDeadLanes.h:105-106
+
+  const MachineRegisterInfo *MRI;
+  const TargetRegisterInfo *TRI;
+
----------------
Keep member variables together below here


================
Comment at: llvm/lib/CodeGen/DetectDeadLanes.cpp:515-534
   if (!MRI->subRegLivenessEnabled()) {
     LLVM_DEBUG(dbgs() << "Skipping Detect dead lanes pass\n");
     return false;
   }
 
   TRI = MRI->getTargetRegisterInfo();
 
----------------
Why is this all repeated here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140382/new/

https://reviews.llvm.org/D140382



More information about the llvm-commits mailing list